[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Error in authz file

From: Peter Lundblad <plundblad_at_google.com>
Date: 2006-11-20 08:28:05 CET

Daniel L. Rall writes:
> On Fri, 17 Nov 2006, David Glasser wrote:
>
> > On 11/17/06, Peter Lundblad <plundblad@google.com> wrote:
> > >A quick look at the code yields that it shold do so. I haven't tried
> > >it and don't know why it complains about the 's', though. So, if the
> > >quoted
> > >config file is the one that generates the error, then this might be a
> > >bugt.
> >
> > I think this patch fixes it. Also fixes an error leak. Have to run
> > now, and have merely determined that it compiles; somebody else should
> > sanity-check, run (and write?) tests, and commit.
>
Ouch! I said it was a quick look, right? ;) More scaring is that I,
according to the log message, already reviewed this and missed it back
then as well:-(

> I've tested this patch, committed it to trunk, and nominated it for
> backport to the 1.4.x line. We already had a test for invalid authz
> files -- subversion/tests/cmdline/authz_tests.py:broken_authz_file()
> -- but it didn't test the specific error message. FWIW, I've add a
> comment character to it.
>

Did you try merging it? It causes conflicts here.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 20 08:28:33 2006

This is an archived mail posted to the Subversion Dev mailing list.