[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22349 - trunk/subversion/libsvn_subr

From: David James <james_at_cs.toronto.edu>
Date: 2006-11-20 04:46:24 CET

On 11/19/06, lgo@tigris.org <lgo@tigris.org> wrote:
> Reimplement svn_path_is_absolute. To improve its performance, don't use
> the slow apr_filepath_root function.
>
> * subversion/libsvn_subr/path.c
> (svn_path_is_absolute): replace call to apr_filepath_root with a custom
> and faster implementation

Excellent work, Lieven! This implementation should have great
performance characteristics. It's exactly the implentation I was
thinking of.

A few questions:
 1. Should the #if block apply to CYGWIN as well as WIN32? I think
that cygwin allows for H:/ paths as well.
 2. Is the "pool" argument still needed? If not, we should remove it
(and update all callers), so as to save the caller the overhead of
creating a pool.
 3. Do you plan to update svn_path_is_root with a similar performance fix?

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 20 04:46:47 2006

This is an archived mail posted to the Subversion Dev mailing list.