[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] support for progress information in ra_svn

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-11-18 20:22:31 CET

On 11/18/06, Stefan K√ľng <tortoisesvn@gmail.com> wrote:
> Erik Huelsmann wrote:
>
> > Well, I took your comments to hart: before adding progress support, I
> > found out our network activity can't be canceled, so, last week, I
> > added cancellation support. I guess that's what all users expect, but
> > GUI users even more than others.
> >
> > The attached patch should add progress support at the same basic level
> > as currently supported by ra_dav to ra_svn, but since our client
> > doesn't install a progress callback, there's no way testing it for me.
> >
> > Could you test the patch with subclipse/TSVN for me please?
>
> Tested your patch with TSVN built against the Subversion trunk. Works
> perfect!

r22340.

> One thing I noticed while compiling Subversion trunk: even with all
> networking disabled, I need to link against zlib. Is there a reason for
> this? Before, zlib was not required (only if using the ra layers).

Yes, we were wrong before: libsvn_subr has a compressing stream.
Before, when no zlib was used, it wouldn't compress. This however
would mean you couldn't count on it being able to read back data off
it you had written to it with a different version... (ie total
brokenness).

We decided to make it a requirement because of it, but also, the new
svndiff1 code uses zlib for self-compressing fulltexts.

bye,

Erik.
Received on Sat Nov 18 20:22:48 2006

This is an archived mail posted to the Subversion Dev mailing list.