Re: [PATCH] Perl editor thunk blows stack

Geoff Richards <qef <at> ungwe.org> writes:
> This is reproducible, but not easily, hence no tests. I'm not sure how
> I'd go about writing them anyway, and I haven't got the time right now.

Committed, thanks. I am very surprised this hasn't been caught until now.

> The patch makes my code work, and the tests still work too. The stack
> still seems to be getting bigger where it shouldn't, but not as much.
> Either I'm misinterpretting that or there's another bug somewhere else,
> but this fix definitely makes things better.

Can you see where the stack was extended? anywhere other than the xpush's
in the thunk caller?

Cheers,
CLK

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 18 03:55:42 2006