Re: [PATCH] Implement cancelation callback in ra_serf

On 11/16/06, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> On 11/16/06, Erik Huelsmann <ehuels@gmail.com> wrote:
> > To that extent I'm wondering if this patch is enough: there should
> > probably be a callback call somewhere which gets triggered when blocks
> > of data are being received or sent (which is what ra_dav and ra_svn
> > do).
>
> Nah, this loop is always called whenever there is data to process, so
> this is the right place to check cancellation within ra_serf.
>
> I'll try to look at it this weekend if you don't have luck building it
> yourself before then... -- justin

Well, I got it to build. It was a combination of problems with
self-built apr libraries and libtool.

The callback seems to work, although the serf-context-runner gets
canceled itself too with my testcase (Ctrl-C), so it took me a while
before I got the 'signal caught' error from the callback.

So, I guess that for any interruption not using signals (a UI for
example) should benefit from the callback.

I'll commit it shortly.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 17 21:08:17 2006