Re: [PATCH][INCOMPLETE-DIRECTORIES] Follow-up to r22198

On 11/13/06, Madan U Sreenivasan <madan@collab.net> wrote:
> Please find attached a follow-up to r22198 and some
> improvements/comments.

Thanks! Committed in r22321, with just a few tweaks. In answer
to your comments:

> [Isn't the 'depth-' prefix redundant here? -madanus]

It's easier for the reader this way. Without the prefix, the words
"empty", "files", "immediates", and "infinity" have their own meanings,
and the reader will have to pause and think whether we're talking
about those meanings or about their special "depth-" meanings.

> [Should this value be represented by the absence of the depth
> field? -madanus]

Yes, but this file describes semantics, not representation. The code
in libsvn_wc that deals with .svn/entries will choose its own way to
represent depths. (During development, it writes them out in full
by name, but for production, yes, the most common depth will be
represented by the empty string.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 17 17:30:10 2006