[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature Request: Revision Properties at Commit Time

From: David Glasser <glasser_at_mit.edu>
Date: 2006-11-15 03:04:59 CET

On 11/14/06, Mark Phippard <markp@softlanding.com> wrote:
> Tim Hill <drtimhill@comcast.net> wrote on 11/14/2006 01:31:38 PM:
> > Comments? Does this suck, has it got legs?
> I just wanted to point out for reference purposes that there is an issue
> filed and there have been past discussions:
> http://subversion.tigris.org/issues/show_bug.cgi?id=1976

Step one towards this would be to allow revprops to be set during the
commit over RA; you can do this now at the repos level but not at the
RA level. I posted a patch a couple of months ago that implemented
this using a new RA call which could only be called between an
ra_get_commit_editor and its ending close_edit; however, this felt
like somewhat of a hack, and I think a better design would involve
adding a "set_edit_props" callback to the delta editor vtable, which
at the very least involves rewriting a bunch of a code to use a new
version of the table.

I got a little lazy and hoped to piggyback off of Garrett's
atomic-moves branch which also revs the delta editor :) One of these
days I'll get back to it, but for now I'm pretty busy. Or folks could
take another look at my patch and decide it's not as hacky as I
thought then.


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 15 03:05:20 2006

This is an archived mail posted to the Subversion Dev mailing list.