crash in 1.4.2 and https

Hi,

It's only the first day of the week after I released TortoiseSVN 1.4.1,
and my inbox already fills up with crashreport mails :(

Fortunately, I got a good stacktrace from those (until now, all 14
reports I got are from the same problem). It seems there's a problem
either in the Subversion library or in neon 0.26.2. I hope you guys can
help me figure this out.

The crash happens with any command accessing a repository via https, but
as I found out not all the time. I'm still in contact with one of the
users who runs into this problem, so I'll keep posting more information
as I get them. BTW: the crash also happens with the command line client
version 1.4.2.

The crash happens because in svn_auth_next_credentials, the second
function parameter is NULL, and the third line after the function start
the line
   provider_set_t *table = state->table;
then accesses the NULL param 'state'.

Here's the stacktrace:

!svn_auth_next_credentials(void * * credentials=0x01bea804,
svn_auth_iterstate_t * state=0x00000000, apr_pool_t * pool=0x00d620d8)
Line 243

request_auth(void * userdata=0x00d621d0, const char * realm=0x01c11e90,
int attempt=2, char * username=0x00d67404, char * password=0x01bea82c)
Line 110 + 0x11 bytes

!get_credentials(auth_session * sess=0x00000000, int attempt=2,
auth_challenge * chall=0x00000000, char * pwbuf=0x00000000) Line 327 +
0x1d bytes

!basic_challenge(auth_session * sess=0x00d673f0, int attempt=2,
auth_challenge * parms=0x01c11e30) Line 346 + 0x1b bytes

!auth_challenge(auth_session * sess=0x00d673f0, int attempt=2, const
char * value=0x00000000) Line 1103 + 0xe bytes

!ah_post_send(ne_request_s * req=0x01bf66b8, void * cookie=0x01c11dc8,
const ne_status * status=0x01bf87bc) Line 1215 + 0x12 bytes

!ne_end_request(ne_request_s * req=0x01bf66b8) Line 1342 + 0x10 bytes

!ne_request_dispatch(ne_request_s * req=0x01bf66b8) Line 1401 + 0xa bytes

!parsed_request(ne_session_s * sess=0x00d7c698, const char *
method=0x00604c18, const char * url=0x00d62298, const char *
body=0x00000000, apr_file_t * body_file=0x00000000, void
(ne_xml_parser_s *, void *)* set_parser=0x00543f40, const
svn_ra_dav__xml_elm_t * elements=0x006064d0, int use_neon_shim=1, int
(void *, int, int)* validate_compat_cb=0x005439d0, int (void *, const
svn_ra_dav__xml_elm_t *, const char * *)* startelm_compat_cb=0x00543b50,
int (void *, const svn_ra_dav__xml_elm_t *, const char *)*
endelm_compat_cb=0x00543d30, int (void *, int, const char *, const char
*, const char * *)* startelm_cb=0x00000000, int (void *, int, const char
*, unsigned int)* cdata_cb=0x00000000, int (void *, int, const char *,
const char *)* endelm_cb=0x00000000, void * baton=0x01beaaa8, apr_hash_t
* extra_headers=0x00d622b0, int * status_code=0x00000000, int
spool_response=0, apr_pool_t * pool=0x00d620d8) Line 715 + 0x6 bytes

!svn_ra_dav__parsed_request_compat(ne_session_s * sess=0x00d7c698, const
char * method=0x00604c18, const char * url=0x00d62298, const char *
body=0x00e13f80, apr_file_t * body_file=0x00000000, void
(ne_xml_parser_s *, void *)* set_parser=0x00543f40, const
svn_ra_dav__xml_elm_t * elements=0x006064d0, int (void *, int, int)*
validate_cb=0x005439d0, int (void *, const svn_ra_dav__xml_elm_t *,
const char * *)* startelm_cb=0x00543b50, int (void *, const
svn_ra_dav__xml_elm_t *, const char *)* endelm_cb=0x00543d30, void *
baton=0x01beaaa8, apr_hash_t * extra_headers=0x00d622b0, int *
status_code=0x00000000, int spool_response=0, apr_pool_t *
pool=0x00d620d8) Line 880 + 0x57 bytes

!svn_ra_dav__get_props(apr_hash_t * * results=0x01beaaf4, ne_session_s *
sess=0x00d7c698, const char * url=0x00d62298, int depth=0, const char *
label=0x00000000, const ne_propname * which_props=0x00606390, apr_pool_t
* pool=0x00d622b0) Line 539
          !svn_ra_dav__get_props_resource(svn_ra_dav_resource_t * *
rsrc=0x01beab80, ne_session_s * sess=0x00d7c698, const char *
url=0x00d62270, const char * label=0x00000000, const ne_propname *
which_props=0x00606390, apr_pool_t * pool=0x00d620d8) Line 559 + 0x1d bytes

!svn_ra_dav__get_starting_props(svn_ra_dav_resource_t * *
rsrc=0x01beab80, ne_session_s * sess=0x00d7c698, const char *
url=0x00d62270, const char * label=0x00000000, apr_pool_t *
pool=0x00d620d8) Line 632 + 0x23 bytes

!svn_ra_dav__search_for_starting_props(svn_ra_dav_resource_t * *
rsrc=0x01beab80, const char * * missing_path=0x01beab84, ne_session_s *
sess=0x00d7c698, const char * url=0x00d68108, apr_pool_t *
pool=0x00d620d8) Line 668 + 0x16 bytes

!svn_ra_dav__get_baseline_props(svn_string_t * bc_relative=0x01beabd4,
svn_ra_dav_resource_t * * bln_rsrc=0x01beabd0, ne_session_s *
sess=0x00d7c698, const char * url=0x00d68108, long revision=-1, const
ne_propname * which_props=0x006063b8, apr_pool_t * pool=0x00d620d8)
Line 814 + 0x1e bytes

!svn_ra_dav__get_baseline_info(int * is_dir=0x00000000, svn_string_t *
bc_url=0x00000000, svn_string_t * bc_relative=0x00000000, long *
latest_rev=0x01beac58, ne_session_s * sess=0x00d7c698, const char *
url=0x00d68108, long revision=-1, apr_pool_t * pool=0x00d620d8) Line
904 + 0x2c bytes

!svn_ra_dav__get_latest_revnum(svn_ra_session_t * session=0x00d62190,
long * latest_revnum=0x01beac58, apr_pool_t * pool=0x00d620d8) Line
1246 + 0x20 bytes

!svn_client__get_revision_number(long * revnum=0x01beac58,
svn_ra_session_t * ra_session=0x00d62190, const svn_opt_revision_t *
revision=0x01beace8, const char * path=0x00d561d0, apr_pool_t *
pool=0x00d620d8) Line 65 + 0x10 bytes

!svn_client__repos_locations(const char * * start_url=0x01beacc8,
svn_opt_revision_t * * start_revision=0x01beaccc, const char * *
end_url=0x01beacd4, svn_opt_revision_t * * end_revision=0x01beacd0,
svn_ra_session_t * ra_session=0x00d62190, const char * path=0x00d561d0,
const svn_opt_revision_t * revision=0x01beace8, const svn_opt_revision_t
* start=0x01beacd8, const svn_opt_revision_t * end=0x01beacf8,
svn_client_ctx_t * ctx=0x00d5d150, apr_pool_t * pool=0x00d620d8) Line
762 + 0x16 bytes

!svn_client__ra_session_from_path(svn_ra_session_t * *
ra_session_p=0x01bead58, long * rev_p=0x01bead60, const char * *
url_p=0x01bead4c, const char * path_or_url=0x00d561d0, const
svn_opt_revision_t * peg_revision_p=0x01beadf0, const svn_opt_revision_t
* revision=0x01beae08, svn_client_ctx_t * ctx=0x00d5d150, apr_pool_t *
pool=0x00d620d8) Line 928 + 0x34 bytes

!svn_client__checkout_internal(long * result_rev=0x00000000, const char
* url=0x00d6dff8, const char * path=0x00d66c78, const svn_opt_revision_t
* peg_revision=0x01beadf0, const svn_opt_revision_t *
revision=0x01beae08, int recurse=1, int ignore_externals=0, int *
timestamp_sleep=0x00000000, svn_client_ctx_t * ctx=0x00d5d150,
apr_pool_t * pool=0x00d560b8) Line 86 + 0x23 bytes

!svn_client_checkout2(long * result_rev=0x00000000, const char *
URL=0x00d6dff8, const char * path=0x00d66c78, const svn_opt_revision_t *
peg_revision=0x01beadf0, const svn_opt_revision_t * revision=0x01beae08,
int recurse=1, int ignore_externals=0, svn_client_ctx_t *
ctx=0x00d5d150, apr_pool_t * pool=0x00d560b8) Line 219 + 0x34 bytes

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org