[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Initialize commit Info to NULL

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-11-11 06:11:17 CET

Hello,

Please find attached a patch for nullifying the commit info when there
is nothing to commit. As mentioned in swig/include/svn_types.swg, it is
a long standing bug and i think, this patch fixes it.

[[
Fix to nullify the commit info when there is nothing to commit.

* subversion/libsvn_client/commit.c
  (remove_tmpfiles, reconcile_errors): Pass svn_commit_info_t as an
  argument to this function to initialize it to NULL when it returns
  SVN_NO_ERROR.

  (svn_client_import2): If log message is not set, initialize the
  svn_commit_info_t to NULL when the function returns SVN_NO_ERROR.

* subversion/bindings/swig/include/svn_types.swig
  (BAD_OUTPUT_INIT_HACK): Remove the comment of bad output init hack
  and include these variables under OUTPARAM data structure.
]]

David: The arguments passed for static function 'reconcile_errors' in
other libraries are not same. So, i think its OK to add an argument for
this function (but i'm unsure). Please review and let me know your
comments.

-- 
Regards,
Bhuvaneswaran

Received on Sat Nov 11 06:11:45 2006

This is an archived mail posted to the Subversion Dev mailing list.