On Nov 4, 2006, at 16:11, Justin Erenkrantz wrote:
> On 11/4/06, Barry Scott <barry@barrys-emacs.org> wrote:
>> I cannot find a #define for DARWIN in the APR include files.
>>
>> $ grep DARWIN /usr/local/svn140/include/apr-0/*
>> /usr/local/svn140/include/apr-0/apr_portable.h:#elif defined(DARWIN)
>> /usr/local/svn140/include/apr-0/apr_signal.h:#if defined(DARWIN) && !
>> defined(__cplusplus) && !defined(_ANSI_SOURCE)
>
> It's added by autoconf to EXTRA_CPPFLAGS and also appears via apr-1-
> config.
>
> % grep DARWIN build/apr_rules.mk
> EXTRA_CPPFLAGS=-DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp
> % ./apr-1-config --cppflags
> -DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp
>
>> I built my own SVN using your two source kits as
>> follows is that has any bearing on the problem.
>>
>> Also isn't testing for DARWIN the wrong thing to do?
>> The key chain is a Mac OS X features not a Darwin feature right?
>
> DARWIN is defined for all Mac OS X systems by APR. The keychain stuff
> is conditional upon it being a Darwin platform and having the keychain
> libs. -- justin
>
Thanks for explaining how this is done. apr-config/apr-1-config gives
me the
DARWIN define. I assume that apr can run on Darwin or Mac OS X so that
would be reasonable.
I also take it that you do not consider it a problem that an svn
header file
publishes an API function that may not be in a the corresponding
library.
e.g. keychain function in header is conditional on DARWIN but the
C source is conditional on SVN_HAVE_KEYCHAIN_SERVICES.
SVN_HAVE_KEYCHAIN_SERVICES is not exposed to users of svn
API.
I notice that SVN does not compile on 10.3 because of a problem with
keychain
header/lib (sorry I did not keep the logs) is that expected.
I'm only supporting 10.4 for pysvn now because of this.
Barry
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 5 10:59:09 2006