[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]remove unwanted tweaks for repos_rev for commit verification

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2006-11-01 15:32:37 CET

Kamesh Jayachandran wrote:
> Lieven Govaerts wrote:
>> Committed this patch in r22191, I did find another location in the
>> revert_replacement_with_props test where repos_rev was tweaked, so I
>> removed that too.
> I have seen that, but it was actually dead code(no usage) along with
> expected_output with no usage down the line thought of removing it on
> a different changeset.
You're right, expected_status and expected_output aren't used at all.
Now I don't care so much about the expected_output, but why not add an
extra status check after the revert is happening?

After all, this is revert_tests.py, so we should at least focus on
checking the behavior of revert in all possible ways, right?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 1 15:33:10 2006

This is an archived mail posted to the Subversion Dev mailing list.