[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22140 - in trunk/subversion: svnsync tests/cmdline tests/cmdline/svnsync_tests_data

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-10-27 23:00:25 CEST

On 10/27/06, David Glasser <glasser@mit.edu> wrote:
> On 10/27/06, rooneg@tigris.org <rooneg@tigris.org> wrote:
> > * subversion/svnsync/main.c
> > (copy_revprops): Add a new sync parameter, which makes us remove
> > revprops in the destination revision that don't exist in the source
> > revision.
> > (do_initialize): Pass FALSE as the sync argument of copy_revprops.
> > (do_synchornize): Pass TRUE as the sync argument of copy_revprops.
> > (do_copy_revprops): Pass FALSE as the sync argument of copy_revprops.
>
> Hmm. Why shouldn't do_copy_revprops delete revprops that get deleted
> in the source?

Well, I figured that the user might have added revprops in the
meantime and would be annoyed if they went away, especially since
we've called the command 'copy-revprops', not 'sync-revprops', and
'copy' doesn't imply 'deletes some stuff' to me.

> (Also, typo in log message "do_synchronize".)

Oops. Will fix.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 27 23:00:47 2006

This is an archived mail posted to the Subversion Dev mailing list.