On Thu, 26 Oct 2006 12:31:38 +0530, Kamesh Jayachandran
<kamesh@collab.net> wrote:
>
>>>> +static svn_error_t *
>>>> +get_src_merge_info(svn_ra_session_t *ra_session,
>>>> + apr_hash_t **src_mergeinfo,
>>>> + const char *src_path,
>>>> + svn_revnum_t src_rev,
>>>> + apr_pool_t *pool)
>>>>
>>> May be we should export this function so that
>>> subversion/libsvn_client/diff.c:get_wc_target_merge_info can make use
>>> of the same. I could see the scope for its usage when we might have
>>> 'mergeaudit' subcommands.
>>
>> Could you explain a bit more in detail. All this function does is call
>> svn_ra_get_merge_info(), and wraps it up in a mergeinfo hash.
> Yes we have a similar code lying out in the function
> 'get_wc_target_merge_info' inside subversion/libsvn_client/diff.c. If
> you make get_src_merge_info public(that is what I meant when I said
> export(static functions are not exported) it ) we can reuse it there and
> possible future consumers like subcommands like 'svn mergeaudit'.
> May be we can call it svn_client_get_mergeinfo_for_single_path() ??
No, these are not the same...
>>>> +{
>>>> + /* Dereference to obtain only the merge info of the src_path
>>>> provided */
>>>> + if (merge_info)
>>>>
>>> No need to check for nullity of merge_info. Unless rel_paths->nelts ==
>>> 0 merge_info will never be null.
>>
>> We need to ensure that src_mergeinfo is set to NULL, thats why the
>> null-check.
> No need to ensure that. Across our code, atleast the places where I have
> seen, the callee always sets the apr_hash_t*. Checking for NULL there is
> redundancy.
>
> In this particular case refer 'svn_repos_fs_get_merge_info' in
> subversion/libsvn_repos/fs-wrap.c you will realize that 'src_mergeinfo'
> will never be NULL.
Please read the code. We also have to extract the inner-hash of the
mergeinfo. To do this, we have to know whether the mergeinfo hash is
non-NULL before we can call the apr_hash_get() function.
Regards,
Madan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 26 19:45:16 2006