[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for revert notification bug (1.4.0 regression)

From: Ed Price <ed.price_at_gmail.com>
Date: 2006-10-20 06:44:45 CEST

> > Looks great to me, applied in r22051. Will propose for backport to
> > 1.4.x once I've confirmed that it works there. Thanks!
>
> Thanks! Unfortunately it looks like the testcases are failing
> on windows (only) according to buildbot. Looking at the logs:
[...]

I can't test on windows so I'm not sure this is it, but I suspect
it's actually because I didn't properly regexp-escape the expected
output, and windows paths have backslashes... Patch attached!

-Ed

[[[

Properly regexp-escape expected output in revert tests added in
r22051. Fixes spurious test failures on windows.

Patch by: Ed Price <ed.price@gmail.com>

 * subversion/tests/cmdline/revert_tests.py
   (revert_propset__dir): Regexp-escape expected output.
   (revert_propset__file): Same.
   (revert_propdel__dir): Same.
   (revert_propdel__file): Same.

]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Oct 20 06:45:00 2006

This is an archived mail posted to the Subversion Dev mailing list.