[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: in the Windows build system, don't create the serf project if openssl isn't available.

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2006-10-19 02:07:40 CEST

On 10/18/06, svnlgo@mobsol.be <svnlgo@mobsol.be> wrote:
> Updated patch based on the remarks of zhakov, who happens to be sitting next to
> me.
>
> Lieven.
>
> Quoting svnlgo@mobsol.be:
>
> > Hi,
> >
> > attached is a patch for the windows build system (gen-win.py) that disables
> > creation of the serf project and all its properties when the openssl package
> > isn't available.
> >
> > OpenSSL is a required package for serf, but it's optional for the rest of the
> > targets so it makes sense to not have it installed.
> >
> > regards,
> >
> > Lieven.
>
> [[[
> In the Windows buildsystem, don't create the serf project if openssl can't be
> found.
>
> * build/generator/gen_win.py
> (__init__): extracted check whether serf is available in a separate
> function.
> (_find_serf): test if both serf and openssl directories are available
> (get_install_targets, get_external_project, get_win_defines,
> get_win_includes, get_win_lib_dirs, get_win_libs,
> write_neon_project_file, write_serf_project_file): instead of only
> checking for serf, also check for openssl.
> ]]]
>
>
Looks good for me, +1 for commit.

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 19 02:07:56 2006

This is an archived mail posted to the Subversion Dev mailing list.