[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] for asvn

From: Peter Samuelson <peter_at_p12n.org>
Date: 2006-10-17 02:03:12 CEST

[Scott Miller]
> o Changed indentation to follow a consistent style.

A couple things. (I'm not involved with asvn in any way, mind you.)
First, your patch got attached as a binary file (MIME type
application/octet-stream) so most mail readers, including mine, didn't
just show it as text - I had to jump through a small hoop to read it.
Try to convince your mail reader to give it a "text/something" type
next time, then it's more convenient to review.

Second, regarding your indentation changes:

@@ -62,9 +82,9 @@
     ref=`expr "$dir" : "$refname/\(.*\)"`
     if [ -z "$ref" ]
     then
- echo .
- else
- echo $ref
+ echo .
+ else
+ echo $ref
     fi

That looks quite misguided to me. First, you messed up the 'else'
line, which was correctly indented at 4 spaces.

Second, this script is for use on Unix, right? The default tab width
on Unix is 8 spaces, so the existing indentation was 4 spaces per
level. You changed it to 2 tabs, which is 16 spaces. (I've converted
tabs to spaces in this mail so you can see what it looks like.)

Your changes seem to indicate that you have a Unix system where tabs
are 4 spaces wide. I'm curious about what system that is.

Honestly, though, if one is going to use a basic indentation level of
anything other than 8, using tabs in the indents is IMO not a great
idea anyway - just use the appropriate number of spaces.

Finally:

@@ -382,7 +418,8 @@
 
 [ "$ACTION" = "pre" ] && pre_checkin $@
 
-$SVN $@
+umask 002
+/usr/local/subversion/bin/svn "$@"
 
 [ $? = 0 -a "$ACTION" = "post" ] && post_checkout $@

What is this /usr/local/subversion/bin/svn? Why did you not want to
use $SVN like everywhere else?

Received on Tue Oct 17 02:03:34 2006

This is an archived mail posted to the Subversion Dev mailing list.