Re: mailer.py, post-commit and SubVersion 1.4 on Windows

On Wed, Oct 11, 2006 at 04:05:50AM -0700, Chatterbox wrote:
> I just downloaded the stable binary distribution of SubVersion 1.4 for
> Windows, the stable Python bindings, and the official mailer.py script.
>
> However, when I try to use the post-commit command, I get the follow
> error:
>
> [snip]
> File "F:\Nazooka\Development\SVN\Nazooka\hooks\mailer.py", line 755,
> in <lambda>
> selection = lambda change: change.action ==
> svn.repos.CHANGE_ACTION_ADD
> AttributeError: ChangedPath instance has no attribute 'action'
>
> I checked the ChangedPath class in the python bindings, and indeed, it
> does not have an 'action' attribute.
>

Ok, so it looks like you're using the trunk version of mailer.py against
the 1.4 bindings. That would normally be fine, except that we seem to
have broken compatibility recently on trunk -- if you use the version of
mailer.py that was distributed in the 1.4 tarball you should be fine.

It looks like r21467 changed mailer.py to depend upon ChangedPath.action,
which was only introduced in r21655, so mailer.py now depends upon
the trunk bindings. So far, so boring, except that mailer.py has the
following text at the top:

# This version of mailer.py requires the python bindings from
# subversion 1.2.0 or later.

... which I take to be as much a statement of intent as a piece of user
documentation.

What's the correct change here?
  a. Fix mailer.py to work against the 1.2 bindings, or,
  b. Just update the mailer.py comment to say that it depends upon
     the 1.5 bindings.

Regards,
Malcolm