[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Was: Enhancement needed in svn status -u

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-10-12 23:37:45 CEST

[Focusing on the Java/test portion of this thread.]

On Wed, 11 Oct 2006, Paul Burba wrote:

> Daniel Rall <dlr@collab.net> wrote on 10/06/2006 03:49:32 PM:
...
> I added a second status test to
> subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests/BasicTests.java,
> it's included in the attached patch. It replicates what my
> temporary test did, but actually *tests* the expected results rather
> than relying on a manual check.

Status.getReposLastCmtKind() seems to be redundant with getReposKind()
(they are both accessors for the same Status.reposKind instance
field), which has existed since 1.3. The method not used by your
patch, so I think we can dump it.

testOODStatus() starts off by performing an "obstructed
checkout"-oriented check, which appears to have been copied from
testBasicCheckout(). This isn't appropriate for testOODStatus(), so
we can dump it. The method's "throws" clause follows the poor pattern
used throughout this class TestCase by declaring "Throwable". We can
narrow this down to "SubversionException, IOException". The method
also contains some block comments with "*" formatting on every line,
which can be switched to line comments.

I made a bunch of other formatting tweaks and JavaDoc improvements,
and have committed this code in an XFAIL-style in r21908.

...
> > > P.S. In testing this patch I used the following hack to make the debug
> > > version of svn status show all the OOD info on the command line. It
> > > also adds a temporary status test to setup various out of date scenarios.
> > > It may prove useful to anyone who tries out this patch:
> >
> > This status test won't be permanent, then? Do we have any OOD info
> > tests?
>
> No, because it relies on the hack I made to the debug version of svn
> status, so it isn't really usefil. The JavaHL test will replace it (see
> above).

Some of the Python status tests do check for "*", but don't test the
individual pieces of "out of date" information retrieved from
repository.

  • application/pgp-signature attachment: stored
Received on Thu Oct 12 23:39:15 2006

This is an archived mail posted to the Subversion Dev mailing list.