[svn] x [fsfs] basic_tests.py failures

In IRC:

[10:57] pburba: On trunk I'm seeing many [svn] x [fsfs] failures in
basic_test.py on Windows
[10:57] pburba: Specifically I'm seeing this error on a commit attempt:
[10:57] pburba: svn: Cannot write to the prototype revision file of
transaction '1-1' because a previous representation is currently being
written by this process
[10:57] pburba: Is this a problem anyone is aware of already?
[11:01] glasser: Is that an error from the new fsfs corruption fix thing?
[11:03] malcolmr: Okay, that's mine, sure.
[11:03] malcolmr: Is this over ra_local?
[11:03] pburba: glasser: svn://
[11:04] malcolmr: Huh. I ran my set of tests over svn:// and they seemed
ok. Are they failing reproducibly?
[11:04] malcolmr: I did run without SASL though - I wonder if that makes
any difference at all?
[11:05] pburba: Yes, basic_tests 7,8,12,13,14,15,27,28,29, tried it twice,
just [svn] x [fsfs]
[11:05] malcolmr: Okay, it's possible that it's a windows-only bug in
libsvn_fs_fs's new anti-corruption code, then.
[11:05] malcolmr: I'll check out cygwin and see if I can reproduce.
[11:06] pburba: malcomr: I can take a look too to see if anything obvious
jumps out at me, now that I know where to look
[11:07] malcolmr: Thanks. r21738 was the commit.
[11:24] malcolmr: pburba: basic_tests passes for me over ra_svn for both
Cygwin and Slackware.
[11:24] malcolmr: I can't test native win32, unfortunately.
[11:25] malcolmr: If you could narrow down _why_ you're having failures,
that might give a clue as to what's triggering the corruption.
[11:26] pburba: malcolmr: I'll do what I can, just finishing up a few
other things then I'll be able to take a look, I'll let you know what I
find.
[11:26] malcolmr: Thanks!

Malcolm,

Log with the failures for just basic_tests.py:

Here are some initial findings:

1) As you can see from the log, the failures occur mostly on commit
attempts, but also on a rm URL and import.

2) Somehow the problem is tied to the basic_corruption test. If that test
is not run all the other tests pass.

3) If svnserve is restarted, subsequent attempts to commit succeed.

4) The SVN_ERR_FS_REP_BEING_WRITTEN is returned from
get_writable_proto_rev_body():

get_writable_proto_rev_body(svn_fs_t * 0x005f4518, void * 0x00c4f6a0,
apr_pool_t * 0x0065a750) line 457
with_txnlist_lock(svn_fs_t * 0x005f4518, svn_error_t * (svn_fs_t *, void
*, apr_pool_t *)* 0x0043d8e0 get_writable_proto_rev_body(svn_fs_t *, void
*, apr_pool_t *), void * 0x00c4f6a0, apr_pool_t * 0x0065a750) line 343 +
17 bytes
get_writable_proto_rev(apr_file_t * * 0x00c4f744, void * * 0x00c65c90,
svn_fs_t * 0x005f4518, const char * 0x00c659fd, apr_pool_t * 0x0065a750)
line 556 + 22 bytes
rep_write_get_baton(rep_write_baton * * 0x00c4f7b4, svn_fs_t * 0x005f4518,
node_revision_t * 0x00c659c8, apr_pool_t * 0x00588210) line 3510 + 46
bytes
set_representation(svn_stream_t * * 0x00c4f888, svn_fs_t * 0x005f4518,
node_revision_t * 0x00c659c8, apr_pool_t * 0x00588210) line 3615 + 21
bytes
svn_fs_fs__set_contents(svn_stream_t * * 0x00c4f888, svn_fs_t *
0x005f4518, node_revision_t * 0x00c659c8, apr_pool_t * 0x00588210) line
3634 + 21 bytes
svn_fs_fs__dag_get_edit_stream(svn_stream_t * * 0x00588260, dag_node_t *
0x00c641d8, const char * 0x0062c670, apr_pool_t * 0x00588210) line 907 +
23 bytes
apply_textdelta(void * 0x00588248, apr_pool_t * 0x00588210) line 2406 + 30
bytes
fs_apply_textdelta(svn_error_t * (svn_txdelta_window_t *, void *)* *
0x00c4faf8, void * * 0x00c4faf4, svn_fs_root_t * 0x0062c560, const char *
0x005751d0, const char * 0x005b2580, const char * 0x00000000, apr_pool_t *
0x00588210) line 2462 + 13 bytes
svn_fs_apply_textdelta(svn_error_t * (svn_txdelta_window_t *, void *)* *
0x00c4faf8, void * * 0x00c4faf4, svn_fs_root_t * 0x0062c560, const char *
0x005751d0, const char * 0x005b2580, const char * 0x00000000, apr_pool_t *
0x00588210) line 804 + 39 bytes
apply_textdelta(void * 0x005751e0, const char * 0x005b2580, apr_pool_t *
0x00588210, svn_error_t * (svn_txdelta_window_t *, void *)* * 0x00c4faf8,
void * * 0x00c4faf4) line 429 + 39 bytes
ra_svn_handle_apply_textdelta(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t
* 0x005b2408, apr_array_header_t * 0x005b24d0, ra_svn_driver_state_t *
0x00c4fb90) line 668 + 36 bytes
svn_ra_svn__drive_editorp(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t *
0x00573138, const svn_delta_editor_t * 0x005735e0, void * 0x00642668, int
* 0x00c4fd58, int 0) line 887 + 28 bytes
svn_ra_svn_drive_editor2(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t *
0x00573138, const svn_delta_editor_t * 0x005735e0, void * 0x00642668, int
* 0x00c4fd58, int 0) line 751 + 29 bytes
svn_ra_svn_drive_editor(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t *
0x00573138, const svn_delta_editor_t * 0x005735e0, void * 0x00642668, int
* 0x00c4fd58) line 772 + 27 bytes
commit(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t * 0x00573138,
apr_array_header_t * 0x005731f0, void * 0x00c4feac) line 969 + 25 bytes
svn_ra_svn_handle_commands(svn_ra_svn_conn_st * 0x005680c0, apr_pool_t *
0x00571120, const svn_ra_svn_cmd_entry_t * 0x00527830 main_commands, void
* 0x00c4feac) line 838 + 31 bytes
serve(svn_ra_svn_conn_st * 0x005680c0, serve_params_t * 0x0012ff30,
apr_pool_t * 0x00571120) line 2305 + 22 bytes
serve_thread(apr_thread_t * 0x0056a180, void * 0x0056a170) line 253 + 25
bytes
LIBAPR! 6eed324e()
KERNEL32! 7c80b683()

- fs 0x005f4518
        pool 0x00571120
+ path 0x005f4b48
"C:/SVN/svn.trunk.copymove/src-trunk.collabnet.trunk/Release/subversion/tests/cmdline/svn-test-work/repositories/basic_tests-2/db"
        warning 0x0040d820 default_warning_func(void *, svn_error_t *)
        warning_baton 0x00000000
        config 0x00000000
+ access_ctx 0x005734f8
+ vtable 0x00549780 fs_vtable
        fsap_data 0x005f4538
        baton 0x00c4f6a0
        pool 0x0065a750
+ file 0x00c4f744
- txn 0x006365d8
+ next 0x005a2380
+ txn_id 0x006365dc "1-1"
        being_written 1
        pool 0x006365a0
+ txn_id 0x00c659fd "1-1"
        lockcookie 0x00c65c90
- b 0x00c4f6a0
+ file 0x00c4f744
        lockcookie 0x00c65c90
+ txn_id 0x00c659fd "1-1"
+ err 0xcccccccc

Does any of this suggest a cause to you?

Paul B.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org