[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit email includes valid date header

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2006-10-11 21:50:17 CEST

William Pietri wrote:
> Hi. Here's my first patch for you folks; I hope I've done this correctly.
>
> The current commit-email.pl script sends out a message without a "Date"
> header. That header is mandatory, but most mail servers will add one if
> it's missing. Qmail is not one of those mail servers, so our commit
> notices ended up being sorted into the wrong end of the inbox or nixed
> by spam filters.
>
> Attached is a patch to fix that. This being Perl, there's more than one
> way to do this, so let me know if you'd like it done differently.

Ping...

Thanks for the patch, William. Does a committer have a chance to take a
look at this patch? If nothing happens in the next few days, I'll file
an issue.

Thanks,
-Hyrum

> [[[
>
> * tools/hook-scripts/commit-email.pl.in: Add RFC822-compliant
> date header to emails; header is mandatory per RFC2822.
>
> ]]]
>
>
> ------------------------------------------------------------------------
>
> Index: tools/hook-scripts/commit-email.pl.in
> ===================================================================
> --- tools/hook-scripts/commit-email.pl.in (revision 21717)
> +++ tools/hook-scripts/commit-email.pl.in (working copy)
> @@ -100,7 +100,9 @@
> }
>
> require Net::SMTP if defined $smtp_server;
> +use POSIX qw(strftime);
>
> +
> ######################################################################
> # Initial setup/command-line handling.
>
> @@ -540,6 +542,8 @@
> push(@head, "To: $to\n");
> push(@head, "From: $mail_from\n");
> push(@head, "Subject: $subject\n");
> + push(@head, "Date: " .
> + strftime("%a, %d %b %Y %H:%M:%S %z", localtime) . "\n");
> push(@head, "Reply-to: $reply_to\n") if $reply_to;
>
> ### Below, we set the content-type etc, but see these comments

Received on Wed Oct 11 21:50:33 2006

This is an archived mail posted to the Subversion Dev mailing list.