[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] code simplification of get_merge_info_for_path

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-10-09 18:38:03 CEST

On Mon, 09 Oct 2006, Kamesh Jayachandran wrote:

> Malcolm Rowe wrote:
...
> >However, I don't understand why this function needs to copy part of path
> >into pool - do we need to modify toappend later?
> >
> >i.e. what's wrong with just this?
> >
> > toappend = &path[parentpath->len + 1];
> >
> >Alternatively, if you do need to copy it, just call apr_pstrdup() rather
> >than pcalloc/strcpy.
...
> Yes Malcom, 'toappend' is not modified by
> 'append_component_to_paths'(Accepts it as const char*).
> Attaching the new patch and log.
>
> With regards
> Kamesh Jayachandran

> [[[
> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>
> No need to duplicate the component dir as it is never modified by
> function('append_component_to_paths') using it.

You can avoid duplicating the description for single changes like this
in the summary. If you want to provide both a summary and a specific
change description (which is generally better, as it saves browsers of
your log message from reading the details), provide a higher-level
description of "why" and/or "what" in the summary, and a very specific
"what" within the following detail section.

> * subversion/libsvn_fs_util/merge-info-sqlite-index.c
> (get_merge_info_for_path):
> No need to duplicate the component dir as it is never modified by
> function('append_component_to_paths') using it.
>
> ]]]

Looks good Kamesh, committed in r21844.

  • application/pgp-signature attachment: stored
Received on Mon Oct 9 18:39:33 2006

This is an archived mail posted to the Subversion Dev mailing list.