[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21825 - in branches/incomplete-directories/subversion: include libsvn_client libsvn_ra_svn libsvn_wc svn

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-10-09 13:53:15 CEST

1)svn_ra_do_diff3 still has the member name as recurse of type
svn_boolean_t should it not be svn_depth_t now?
2)svn_wc_adm_open_anchor has 'depth' of type 'int' should it not be
'svn_depth_t'?
kfogel@tigris.org wrote:
> * subversion/libsvn_client/diff.c
> (struct diff_parameters): New depth field replaces recurse field.
> (diff_repos_repos, diff_summarize_repos_repos, do_diff): Adjust for
> above structure change.
>

> (diff_wc_wc): Add a comment about leaving recurse as a flag.
> (do_merge): Take depth parameter instead of recurse.
>
'do_merge' calls 'svn_client__get_diff_editor' with the new signature.
'do_merge' calls 'svn_ra_do_diff3' with 'depth' rather than 'recurse'.
> (svn_client_diff4, svn_client_diff_peg3, svn_client_diff_summarize2,
> svn_client_diff_summarize_peg2, svn_client_merge3, svn_client_merge_peg3):
> Define new functions, taking depth.
> (svn_client_diff3, svn_client_diff_peg2, svn_client_diff_summarize,
> svn_client_diff_summarize_peg, svn_client_merge2, svn_client_merge_peg2):
> Reimplement as wrappers.
>
>
Signature change of diff_repos_wc of is not logged.
    It should also have info about the change in call to
'svn_wc_adm_open_anchor'.
    Should we not call 'svn_wc_get_diff_editor4' than
'svn_wc_get_diff_editor3' here?
    It should have the info about the change in call to 'svn_ra_do_diff3'.
    It should have the info about the change in call to
'svn_wc_crawl_revisions3'

> * subversion/libsvn_client/client.h
> (svn_client__get_diff_editor): Take depth instead of recurse.
>
Should callers of this new routine be logged?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 9 13:52:41 2006

This is an archived mail posted to the Subversion Dev mailing list.