[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21797 - in trunk: . subversion/tests/cmdline subversion/tests/cmdline/svntest

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-10-07 21:07:19 CEST

David Glasser wrote:
> On 10/7/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
>>
>> Hi,
>> I could not see 'os.environ['SVN_EDITOR']' being execed anywhere in the
>> patch (or my eyes are not effective?)
>
I realized the same after making a comment :).
Now the problem is your svneditor.py seems to edit the file within a
microsecond and hence the temporary file's mtime same. This makes the
svn client binary to think that nothing changed, and hence the testcase
fails. putting a time.sleep(1) before 'foo' to 'bar' conversion makes
the testcases pass.

<snip>
subversion/svn/util.c
 if ((finfo_before.mtime != finfo_after.mtime) ||
      (finfo_before.size != finfo_after.size))
This block always fails and hence no change in the property.
</snip>

With regards
Kamesh Jayachandran
> It's the program that's used by "svn propedit", log message editing, etc.
>
> Thanks for the other note, I'll try to figure out the best thing.
>
> --dave
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 7 21:06:51 2006

This is an archived mail posted to the Subversion Dev mailing list.