[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [crash handling on windows (was subversion 1.4.0 svn checkout crash)

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-10-06 21:52:52 CEST

Garrett Rooney wrote:
> On 10/6/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>
>> Why do you want to implement your own crashhandler if you can use what
>> already exists?
>>
>> The patch here:
>> http://svn.haxx.se/dev/archive-2005-07/1172.shtml
>> and the modifications I made to the crash reporter used in TSVN
>> especially due to that request should be more than enough.
>> The code of the crash reporter dll is here:
>> http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/crashrpt/
>
> What license is that code under? I can't see anything specific in
> that directory, and since TortoiseSVN is GPLed we wouldn't be able to
> use its code directly in Subversion itself due to the viral nature of
> the license.

It doesn't have a real license. It's basically a heavily modified
version of some code example posted on codeproject.com:
http://www.codeproject.com/debug/crash_report.asp
(codeproject requires code posted there to be free for any use if
nothing else is specified)

If you're concerned about the license:
You don't have to ship the dll with the Subversion binaries. In case
someone reports a crash, just point them to some place where they can
download the dll and put it into the same folder as the svn.exe resides.
The only thing required: the dll should be built with VC6 (the same as
svn.exe) to avoid problems with not-installed c-runtime libs.

My patch only installs the handler if the dll is present. If the dll
isn't there, the handler isn't installed and svn.exe behaves as always
(i.e. will crash as before in such cases).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 6 21:53:35 2006

This is an archived mail posted to the Subversion Dev mailing list.