[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [crash handling on windows (was subversion 1.4.0 svn checkout crash)

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-10-06 21:19:56 CEST

Moisei Rabinovich wrote:
> On 10/6/06, *D.J. Heap* <djheap@gmail.com <mailto:djheap@gmail.com>> wrote:
>
> On 10/3/06, Moisei Rabinovich <moisei@gmail.com
> <mailto:moisei@gmail.com>> wrote:
> [snip]
> > For svn windows dev: IMHO under any condition the pop up error
> dialog is not
> > acceptable - it freezes the entire process
> > without report an error back to the caller application that is
> the worse
> > behavior one can imagine for any automation system
> > There are some techniques to prevent windows application to
> raise such a
> > dialogs, I would consider to use it for svn application.
> >
>
>
> I agree -- can you work up a patch to implement this?
>
> DJ
>
>
> I can't work on the patch, no time for that, sorry. It requires a deep
> knowledge of the code base that I do not have.
> For the one who (and whether) is going to implement it, I recommend to
> look at
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/debug/base/seterrormode.asp
> <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/debug/base/seterrormode.asp>
> In particular, SetErrorMode(SEM_FAILCRITICALERRORS); can do the job,
> if the rest of the code matches the conditions defined in the function
> description.
> Also _set_se_translator
> (http://msdn2.microsoft.com/en-us/library/5z4bw5h5.aspx)
> could help to get a stack trace on crash and save it in the separate
> file, so it can be investigated later by the developers.

Why do you want to implement your own crashhandler if you can use what
already exists?

The patch here:
http://svn.haxx.se/dev/archive-2005-07/1172.shtml
and the modifications I made to the crash reporter used in TSVN
especially due to that request should be more than enough.
The code of the crash reporter dll is here:
http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/crashrpt/

Seriously, I'm starting to sense a "not invented here" syndrom...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 6 21:20:15 2006

This is an archived mail posted to the Subversion Dev mailing list.