[PATCH] Re: svn propedit URL

On 10/1/06, David Glasser <glasser@mit.edu> wrote:
> I think this patch is kind of ugly, but necessary to achieve this
> functionality. I would appreciate eyes before committing it.

Oops, and here's the log message:

[[[
Extract the validation and canonicalization of svn:* properties from
svn_wc_prop_set2 into a new API, which could theoretically be used
for "svn propset URL".

* subversion/include/svn_wc.h
  (svn_wc_canonicalize_svn_prop): New API to validate and canonicalize
   svn:* properties.
  (svn_wc_canonicalize_svn_prop_get_file_t): New callback type for above API.

* subversion/libsvn_wc/props.c
  (svn_wc_canonicalize_svn_prop): Implement new API (extracted from
   svn_wc_prop_set2).
  (getter_baton): New baton implementation for new callback.
  (get_file_for_validation): New function, implementing new callback
type; contents
   extracted from validate_eol_prop_against_file.
  (validate_eol_prop_against_file): Use callback instead of direct WC access.
  (svn_wc_prop_set2): Use new API for property validation and canonicalization
   instead of doing it directly.
  (validate_prop_against_node_kind, validate_eol_prop_against_file,
   svn_wc_parse_externals_description2): Allow an argument which is
only used in error
   messages to be an URL.
]]]

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org