Garrett Rooney wrote:
> On 9/29/06, David Glasser <glasser@mit.edu> wrote:
>> (I assume there must have been discussion of this before, but I'm
>> having trouble finding it.)
>>
>> It would be useful to support "svn propedit" on URLs. The obvious
>> problem with modifying properties on URLs is accidentally overwriting
>> somebody else's changes. While this is clearly a problem for propset
>> and propdel, it's not as big of a deal (in theory) for propedit: svn
>> could remember the revision of the property being edited, and pass it
>> through the various layers of propset, and the operation would fail if
>> it was out of date. This can be implemented with the current RA API;
>> it just needs a new client API (and 'svn' changes).
>>
>> I'm specifically proposing the following API change. What do folks
>> think?
>
> There are two gotchas with edit type commands on URLs. Neither are
> showstoppers, but you need to be aware of them. First, you need to be
> sure to avoid race conditions where you start editing, someone commits
> a change, and then you hit save and commit. With files this can be
> handled by remembering what version of the file you started with and
> using that as your initial rev during the commit. There should be a
> similar thing you can do with properties.
Did you miss the part of David's mail where he said pretty much exactly
that? :-)
> Second, finding a UI for
> entry of log messages, since it's kind of lame to pop up one editor to
> make your change, then a second one to enter a log. I don't
> personally have an issue with that being the UI, but other people have
> expressed problems with it in the past.
I think it's fine as a default UI. Remember, folks can do the following
to get down to a single editor pop-up:
svn propedit http://server.com/some/path foo \
-m "Modify the `foo' property on /some/path"
In fact, we could consider having Subversion just use a stock log
message for such a single-property-only change (it can always be tweaked
later).
--
C. Michael Pilato <cmpilato@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Fri Sep 29 17:34:16 2006