[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Correct approach to detect the presence of apr_hash_clear in apr

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2006-09-27 21:05:09 CEST

Daniel Rall wrote:
> On Thu, 21 Sep 2006, Garrett Rooney wrote:
>
>
>> On 9/21/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
>>
>>> Hi All,
>>> Find the attached patch and log which in my opinion a correct way to
>>> detect apr_hash_clear in an available apr.
>>> Tested the same in apr-0.9.7 and apr-1.3.0.
>>>
>> Honestly, I think it's silly to waste people's CPU time on autoconf
>> checks for this. We know what version of APR it will show up in, so
>> there's no reason to jump through the hoops of compiling a test
>> program to see if it's there.
>>
>
> Furthermore, we'd have to add additional autoconf checks the next time
> we needed an API from APR which isn't present in all the versions of
> it we support. Using a macro is more easily supportable.
>
Even further more, if it doesn't work on Windows, it can't go in.
Autoconf doesn't work on Windows. QED.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 27 21:05:52 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.