[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue 2533: status -u doesn't show remote propchanges on the root folder

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2006-09-26 20:02:13 CEST

Paul Burba wrote:
> ..
> This occurs because in r21638 when close_directory() processes the root WC
> dir, it uses tweak_statushash() to add the WC root dir's status info to
> itself (i.e. db->statii) when a change occurs. Later close_directory()
> calls handle_statii() to report on all of the dir's children, but
> db->statii now contains status info on itself, so the root dir is
> reported. But here comes the problem, we then call is_sendable_status()
> to see if we want to report on the root dir, and with the --verbose option
> in use (i.e. eb->get_all == TRUE) the answer is always yes, so we report
> the root dir a second time (and incorrectly at that, as issue 2533 still
> plagues this redundant report).
Correct analysis.

> I believe the attached patch solves the problem, please take a look if you
> have a chance.
> Paul B.
> [[[
> Follow-up to r21638, prevent double status reporting of changed WC root
> with -v.
> * subversion/libsvn_wc/status.c
> (close_directory): When root WC dir is out of date, stop reporting it
> twice when edit_baton get_all member is set.
> ]]]
We need some more status regression tests, do you mind writing one for
this scenario? I'll probably add some more later.



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 26 20:02:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.