[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add '+' character if it is a copy

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-09-25 18:50:50 CEST

On Sat, 23 Sep 2006, Bhuvaneswaran Arumugam wrote:

> On Fri, 2006-09-22 at 10:31 -0700, Daniel Rall wrote:
> > On Fri, 22 Sep 2006, Bhuvaneswaran Arumugam wrote:
> >
> > > On Thu, 2006-09-21 at 13:09 -0700, Daniel Rall wrote:
> > > > On Thu, 21 Sep 2006, Bhuvaneswaran Arumugam wrote:
> > > > ...
> > > > > If the path is a copy, add '+' character to the log message displayed in
> > > > > SVN_EDITOR.
> > > > >
> > > > > Patch by: me
> > > > > Kamesh Jayachandran <kamesh@collab.net>
> > > > >
> > > > > subversion/svn/util.c:
> > > > > * (svn_cl__get_log_message): Define new variable 'iscopy'('+'). If the
> > > > > path is a copy, add it to the log message displayed in SVN_EDITOR.
> > > >
> > > > David James and I went over this patch, and came up with a revised
> > > > version (to avoid changing the level of indention), which produces the
> > > > following output for copies/moves:
> > >
> > > Thank you! Committed this fix in r21604.
> >
> > Bhuvaneswaran, I didn't intend to imply approval to commit this change
> > yet, as I first wanted to give other developers a chance to review the
> > user experience impact.
>
> Oh, it's my mistake. I did not realize that it needs approval from other
> developers. Please let me know if i should revert it back. Thank you.

No, don't back it out. I was trying to provide other developers
enough time to respond to a change in user interface, but they can do
so in post-commit review.

  • application/pgp-signature attachment: stored
Received on Mon Sep 25 18:52:24 2006

This is an archived mail posted to the Subversion Dev mailing list.