[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add property handling to mailer.py's commit messages

From: Mathias Weinert <wein_at_mccw.de>
Date: 2006-09-25 15:09:14 CEST

Alan Barrett wrote:
> On Mon, 25 Sep 2006, Mathias Weinert wrote:
> > New configuration parameters:
> > show_props configure which property changes to report
> > (valid options are any combination of
> > 'add copy modify delete')
> > show_props_svn configure whether 'svn:' properties shall
> > also be reported
> > generate_propdiffs configure for which property changes diffs
> > shall be created
> > (valid options are any combination of
> > 'add copy modify delete')
> > generate_propdiffs_svn configure whether diffs for 'svn:' properties
> > shall also be reported
>
> Separating properties into "svn:*" and "others" seems too restrictive.
> What if somebody wants to ignore the svnmerge-integrated property, or
> ignore svn:mergeinfo while not ignoring svn:executable? I suggest using
> a regular expression to decide which properties to ignore.

The idea behinds this was that if someone make use of self defined
properties he might not be interested in the internal ones. But I agree
that with regular expressions one has much more possibilities to
select properties - including the exclusion of all properties starting
with 'svn:'. So I implemented this feature. Here comes the new part of
the configuration file:

# When set to a regular expression all properties matching this regular
# expression will not be included in the summary of changed properties.
# Example (ignore all internal properties, i. e. all properties
# starting with 'svn:'):
# ignore_props = ^svn:
ignore_props = ^svn:

[...]

# When set to a regular expression all properties matching this regular
# expression will be ignored by the selection made by
# generate_propdiffs.
# Example (ignore all internal properties, i. e. all properties
# starting with 'svn:'):
# ignore_propdiffs = ^svn:
ignore_propdiffs = ^svn:

>
> > +# Meaning of the possible values:
> > +# add: lists all added properties including the ones added for
> > +# newly added paths
> > +# copy: lists all properties which were implicitly added by making
> > +# a copy of a path and not changed or removed after copying
> > +# modify: lists all modified properties, including the ones that were
> > +# added by making a copy of a path and modified afterwards
> > +# (within the same commit)
> > +# delete: lists all removed properties including the ones for removed
> > +# paths
> > +show_props = add copy modify
>
> I'd like a way of displaying diffs for deleted properties, but not
> displaying anything about properties for a deleted path; the fact that
> the path was deleted is enough for me.
>
> Perhaps split the "delete" keyword into two keywords with the two
> meanings, or perhaps guess which of the two behaviours is wanted from
> whether the generate_diffs option contains the "delete" keyword.

Thanks for this idea. I split delete into delete (for deleted
properties) and delete_path (for properties of deleted paths). I also
split add into add and add_path and renamed copy to copy_path. The
comment now reads:

# Specify which types of property changes mailer.py will report as a
# summary at the top of the message, after the summary of changed paths.
# Valid options are any combination of 'add_path add copy_path modify
# delete_path delete'.
# If the show_props option is empty, no list of changed properties will
# be created.
# Meaning of the possible values:
# add_path: lists all properties added with a newly added paths
# add: lists all added properties not including the ones added
# for newly added paths
# copy_path: lists all properties which were implicitly added by
# making a copy of a path and not changed or removed after
# copying
# modify: lists all modified properties, including the ones that
# were added by making a copy of a path and modified
# afterwards (within the same commit)
# delete_path: lists all properties removed with a path
# delete: lists all removed properties not including the ones for
# removed paths
show_props = add modify delete

[...]

# Specify which types of property changes mailer.py will create
# diffs for. Valid options are any combination of
# 'add_path add copy_path modify delete_path delete'. If the
# generate_propdiffs option is empty, no diffs are created.
# Note that this only affects the display of property diffs - the mentioning
# of property changes in the summary at the top of the message is regulated
# by show_props and listed regardless of this option's value.
# See show_props for an explanation of the possible values.
generate_propdiffs = add modify delete

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 25 15:09:41 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.