[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] added support for 'X:' paths on Windows (issue 1711)

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2006-09-23 17:45:42 CEST

D.J. Heap wrote:
> On 9/21/06, Daniel Rall <dlr@collab.net> wrote:
>> On Tue, 19 Sep 2006, svnlgo@mobsol.be wrote:
>> ...
>> > this is a patch for issue 1711, so you can use that ticket.
>> >
>> > It's too bad nobody has time to review this patch though. It's the
>> last part
>> > from a series of patches to handle both issue 1711 and issue 2556.
>> As far as
>> > I'm concerned both issues can be closed after committing this patch.
>> >
>> > I know it's a large patch and it's Windows only, both more than
>> half of the
>> > patch are much needed extra C and Python testcases.
>>
>> I committed two small refactorings from this patch which are unrelated
>> to issue 17111, and not Windows-specific. The patch looks pretty good
>> to me, but I lack a Windows dev environment in which to test it.
>>
>
>
> I reviewed and tested this and it looks good, +1 to commit. Thanks
> Lieven!
>
> DJ
Committed in r21621, thanks for the review!

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 23 17:46:07 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.