Re: APR version/API compatibility issues

On 9/21/06, Daniel Rall <dlr@collab.net> wrote:
> Okay, I'm committing a change which makes an APR_VERSION_AT_LEAST()
> macro available.
>
> How about the svn_hash_clear() function I committed to
> svn_hash.h/hash.c a couple days ago? It's basically just a wrapper
> around or re-implementation of APR's apr_hash_clear() API (also found
> in APR 1.3.0). Should I then do away with svn_hash_clear(), and
> conditionally define apr_hash_clear() in svn_compat.h?

That seems nice and consistent. In that case, it might make sense to
rename 'svn_hash_clear' to 'svn__hash_clear', so as to make clear that
it's a private function which shouldn't be called directly (except
through the macro).

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 21 18:50:31 2006