Daniel Rall wrote:
> On Wed, 20 Sep 2006, Kamesh Jayachandran wrote:
> ...
>
>> Follow up to 'compile failures with versions of APR older than 1.3.0'
>> caused by r21561.
>>
>> * subversion/libsvn_subr/hash.c
>> Including svn_private_config.h.
>> (svn_hash_clear): use 'configure' detected 'HAVE_APR_HASH_FUNC' to decide
>> about the availability of 'apr_hash_clear'.
>> * build/ac-macros/apr.m4
>> (SVN_LIB_APR): Check for 'apr_hash_clear', if available set
>> HAVE_APR_HASH_CLEAR.
>>
>
> I was considering using Kamesh's fix for a permanent solution to the
> compilation problem I introduced yesterday for pre-1.3.0 APR libraries
> (which David Glasser fixed, and I spruced up), which boiled down to
> usage of the APR_VERSION_AT_LEAST(1, 3, 0) macro, which wasn't
> introduced until about a month ago (in 1.3.0 itself).
>
> However, after talking things over on IRC, a more easily maintainable
> solution was suggested -- SVN_APR_VERSION_AT_LEAST(). This macro will
> both fix this particular case nicely, and allow us to more easily
> leverage any future new APIs from APR.
>
> As this isn't a publicly accessible macro, but does need to be shared
> across our code base, it was suggested that I put it in
> private/svn_compat.h. I'm attaching a patch which does that, and
> makes use of the macro.
>
Looks fine with me. Did not see this (due to sudden change in the
original discussion).
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 21 14:49:26 2006