[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Show more information in diff labels in mailer.py

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-09-20 23:32:50 CEST

On Wed, 20 Sep 2006, Mathias Weinert wrote:
> If you want to use the diffs as input for a patch program we should
> provide two diffs. One is the copy as described above and one is the
> succeeding modify.

Please, no...

> On the other hand as a human reader I will always prefer only one diff
> which only contains the changes after the copy action beacuse the
> information that this is a new file as a result of a copy I can find
> in the enhanced texts in brackets (or in the header of the diff or at
> the beginning of the message, as Daniel pointed out).

> So what do we have until now?
> - Some people like the more verbose texts and some don't.
> - Most people only use the diffs for human consumption while several
> use it as input for a patch program.
> This again makes me think about an option diff_style or something
> similar, althoguh I am not totally convinced that this is necessary.
> And BTW it won't help people who cannot set personal diff options as
> it is toady for recipients of *the* Subversion repository changes.

The primary use cases for the change notification emails generated by
this script are, in order of priority:

1) Code review.
2) Patch repository.

#1 is the primary use case, with #2 being more of a bonus that we
should try hard not to lose.

  • application/pgp-signature attachment: stored
Received on Wed Sep 20 23:34:08 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.