On 9/20/06, Daniel Rall <dlr@collab.net> wrote:
> On Wed, 20 Sep 2006, rooneg@tigris.org wrote:
>
> > Author: rooneg
> > Date: Wed Sep 20 09:09:10 2006
> > New Revision: 21565
> >
> > Log:
> > Convert an error generating function into an error generating macro.
> >
> > * subversion/libsvn_wc/log.c
> > (signal_error): Replaced with...
> > (SIGNAL_ERROR): This, a new macro version of signal_error, which allows
> > it to return errors with a more useful line number in them.
> > (log_do_file_xfer, log_do_modify_entry, start_handler): Use new macro.
>
> We should use this pattern in the C tests. Several of them are using
> a function, so line numbers for any returned errors aren't quite
> right.
We should be using this pattern in lots of places ;-) I'm fixing them
as I encounter them, but if someone wants to make a sweep through the
various libraries and find all the little error generating wrapper
functions and replace them with error generating macros, more power to
them.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 20 20:29:19 2006