[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][libsvn_wc] Issue 2607: Post-commit working copy processing exhibits O(n^2) behaviour

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-09-20 14:13:33 CEST

On Tue, Sep 19, 2006 at 10:29:11PM +0200, Erik Huelsmann wrote:
> >Are there any situations in which the fact that we're processing commit
> >items out of order would make a difference?
>
> Well, I sent the patch to zhakov and included a list of failing tests.
> I thought that they were caused by out-of-order processing, but I've
> added code to sort the adm's back into queue order before running
> their logs.
>

Oh, I didn't realise we were getting failures. Okay. (We should probably
ditch the sorting code if it turns out not to make a difference.)

I reduced the failing svnlook test case to the attached reproduction
recipe. Unfortunately, I got lost in the maze of log files (which I'm
not very familiar with), so I don't think I'm going to get very far
debugging this.

For reference, the script produces the following output:
$ ./repro
Checked out revision 0.
A wc/A
A wc/A/x
Adding wc/A
Adding wc/A/x
Transmitting file data .
Committed revision 1.
A wc/B
D wc/B/x
Adding wc/B
Deleting wc/B/x
../svn-trunk/subversion/libsvn_client/commit.c:874: (apr_err=200000)
svn: Commit succeeded, but other errors follow:
../svn-trunk/subversion/libsvn_client/commit.c:892: (apr_err=155009)
svn: Error bumping revisions post-commit (details follow):
../svn-trunk/subversion/libsvn_wc/log.c:499: (apr_err=155009)
svn: In directory '/home/malcolm/wc/B'
../svn-trunk/subversion/libsvn_wc/log.c:1629: (apr_err=155009)
svn: Error processing command 'committed' in '/home/malcolm/wc/B'
../svn-trunk/subversion/libsvn_wc/log.c:1032: (apr_err=155009)
svn: Log command for directory 'x' is mislocated

Regards,
Malcolm

#!/bin/sh

alias svn=~/svn/svn-objdir/subversion/svn/svn

rm -rf repo/ wc/
svnadmin create repo
svn co file://`pwd`/repo wc

svn mkdir wc/A
touch wc/A/x
svn add wc/A/x
svn ci wc -m log_r1

svn cp wc/A wc/B
svn rm wc/B/x
svn ci wc -m log_r2

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 20 14:13:51 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.