David Glasser wrote:
> On 9/19/06, dlr@tigris.org <dlr@tigris.org> wrote:
>> --- trunk/subversion/libsvn_subr/hash.c (original)
>> +++ trunk/subversion/libsvn_subr/hash.c Tue Sep 19 15:42:07 2006
>> @@ -21,6 +21,7 @@
>> #include <stdlib.h>
>> #include <limits.h>
>> #include <assert.h>
>> +#include <apr_version.h>
>> #include <apr_pools.h>
>> #include <apr_hash.h>
>> #include <apr_file_io.h>
>> @@ -429,3 +430,25 @@
>>
>> return SVN_NO_ERROR;
>> }
>> +
>> +
>> +/*** Misc. hash APIs ***/
>> +
>> +svn_error_t *
>> +svn_hash_clear(apr_hash_t *hash)
>> +{
>> +#if APR_VERSION_AT_LEAST(1, 3, 0)
>
> APR_VERSION_AT_LEAST is new in 1.3.0, so this breaks the build for
> pre-1.3.0.
>
> I am committing a quick fix to change this to "#ifdef
> APR_VERSION_AT_LEAST" to preserve the ability to build trunk; somebody
> who knows APR better than me might want to make a better change.
> (#ifdef does work for macros, right?)
>
> --dave
>
I don't think.
I believe having AC_CHECK_FUNC based 'apr_hash_clear' detection should
be the way to go.
I am cooking the same.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 20 09:17:28 2006