[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21546 - trunk/subversion/tests/libsvn_repos

From: Karl Fogel <kfogel_at_google.com>
Date: 2006-09-20 00:49:35 CEST

philip@tigris.org writes:
> Log:
> * subversion/tests/libsvn_repos/repos-test.c (commit_editor_authz): Tweak
> pool usage to avoid a core dump with pool debugging and --enable-dso.
>
> Patch by: Malcolm Rowe <malcolm-svn-dev@farside.org.uk>

How exactly does this prevent a core dump? Since 'subpool' is just a
child of 'pool', I can't see a safety issue with allocating in the
latter instead of the former. A scalability issue, sure, but safety?

How does the combination of pool debugging and --enable-dso cause such
a counterintuitive result?

-Karl

> Modified:
> trunk/subversion/tests/libsvn_repos/repos-test.c
>
> Modified: trunk/subversion/tests/libsvn_repos/repos-test.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/libsvn_repos/repos-test.c?pathrev=21546&r1=21545&r2=21546
> ==============================================================================
> --- trunk/subversion/tests/libsvn_repos/repos-test.c (original)
> +++ trunk/subversion/tests/libsvn_repos/repos-test.c Mon Sep 18 16:38:39 2006
> @@ -1561,7 +1561,7 @@
> /* Open directory /A, to which we have read/write access. */
> SVN_ERR(editor->open_directory("/A", root_baton,
> SVN_INVALID_REVNUM,
> - pool, &dir_baton));
> + subpool, &dir_baton));
>
> /* Test denied file addition. Denied because of a conflicting rule
> on the file path itself. */
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 20 00:49:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.