[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Show more information in diff labels in mailer.py

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-09-19 23:03:42 CEST

+1 on Justin's suggestion of moving the revision number into the
parenthesized text. (I was going to suggest the same.)

On Tue, 19 Sep 2006, Peter Samuelson wrote:

> I think the parenthesized text is much too verbose:

While there's certainly room to shorten the text, I don't dislike the
explicitness of the messages. However, isn't this information
redundant with the A/D/etc. tags which come in the meta data at the
beginning of the change log notification email?

> Now for file copies, we have a problem:
> > --- file1 Sun Sep 9 01:46:40 2001 (r1, copy source)
> > +++ dir2/file7 Sun Sep 9 07:20:00 2001 (r3, unchanged copied file)
> Is this an empty diff (just a diff header and nothing else), or is it
> the full contents of the file? Either way, you cannot expect diff -R
> to do the right thing, unless file1 is labeled as /dev/null.

At first I thought that if we're printing this header, we should show
the full content of the file in the diff. However, that wouldn't be
orthogonal with what I'd want for the case below...
> > --- file1 Sun Sep 9 01:46:40 2001 (r1, copy source)
> > +++ dir3/file8 Sun Sep 9 10:06:40 2001 (r4)
> This one is copy + modify. Is this supposed to show a diff between
> file1 and file8, or the full contents of file8?

I'd want to see file1 and file8.

  • application/pgp-signature attachment: stored
Received on Tue Sep 19 23:05:02 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.