[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Server-side Cyrus SASL support

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-09-19 17:20:48 CEST

On 9/18/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 9/15/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
>
> > Also, before testing this, please apply the client-side fix that I
> > mentioned in my previous e-mail. Without it the client will lose the
> > last error message returned by the server (this happens because
> > last_err is allocated in a subpool, so we have to use it before
> > restarting the enclosing loop, which clears the pool). With that fix
> > in place, if the authentication still fails, you should at least get a
> > decent error message.
>
> Committed the client side patch in r21529. Now on to trying the
> server side stuff again...

And hey, it turns out it work! If I had to guess I'd say that I
typoed something the last time I played with this, or one of your
recent bugfixes helped things.

Anyway, a few comments. It would be nice to stick a sasl-howto.txt
file in the notes directory, with examples of how to set this up (i.e.
the subversion.conf and saslpasswd2 stuff you need to be aware of).
Perhaps more importantly, it would be nice to have some instructions
for how to run the test suite over this stuff. I'm thinking a
--enable-sasl flag that would turn on the sasl stuff in svnserve.conf
for new repositories, and then the user would simply need to add a few
users/passwords via saslpasswd2 before starting the test suite.
Finally, now would be a good time to take a look at those outstanding
patches you had for additional sasl magic ;-)

Thanks for being so patient on this stuff!

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 17:21:15 2006

This is an archived mail posted to the Subversion Dev mailing list.