Re: svn commit: r21540 - in trunk/subversion: libsvn_fs_fs tests/cmdline tests/libsvn_fs

On 9/19/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> Oh, okay. But the same applies to all the other contents of the noderev
> structure :-), doesn't it? I know I'm probably just being picky -
> I'll make the change myself if you've no objections.

Well, arguably no -- the other parts of the noderev structure need to
be changed when their actual value changes, whereas this flag needs to
be cleared whenever you make *any* change to the structure, which
could happen in many places.

I guess my point is, I'm not sure where I'd put documentation of the
fact that the flag needs to be cleared on *any* modification, whereas
this doesn't leave a chance to forget.

> Sorry I wasn't clear. We're relying on a certain behaviour from
> svn_fs_node_created_rev() that's not well documented, specifically that
> it returns a real revision when called on the root of an unmodified
> transaction. I was thinking that we should document that in the
> doc-comments for that function.

Yeah, sounds reasonable.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org