Re: JavaHL : EXCEPTION_ACCESS_VIOLATION in checkout when destPath equals empty string

james82@gmail.com wrote on 09/18/2006 07:06:05 PM:

> On 9/15/06, Alexandre Pique <apique@isoft.fr> wrote:
> > I have an EXCEPTION_ACCESS_VIOLATION when I call the checkout method
of
> SVNClientInterface with an empty destPath. I think it could be catch
easily.
>
> Yes, I agree. We should definitely catch this case. If you'd like to
> file an issue about this, please consider it buddied.

I did a quick check. It looks like the code checks for NULL, but not an
empty string. I did not see anywhere in the code where it checks for an
empty string on any API. Is the checkout API the only one that would have
this problem? Do the other SVN API's do their own checks internally and
this one does not?

It is kind of too bad that the code is not really setup so that these sort
of validations do not just take place in the Java layer. I guess I feel
that way because I know Java and not really C++ so would rather make the
change there, but there is also the unnecesary JNI calls.

It looks like this change would have to take place in the C++ code though.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 02:05:07 2006