On 9/18/06, Daniel Rall <dlr@collab.net> wrote:
> On Mon, 18 Sep 2006, D.J. Heap wrote:
>
> > On 9/18/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> > >On 9/18/06, Daniel Rall <dlr@collab.net> wrote:
> > >
> > >> I'd be okay with that. Though, if you carry your Subversion config
> > >> file between machines with different versions of Neon, or upgrade your
> > >> Neon on your machine (or an administrator does it for you), you might
> > >> never know about the option. Perhaps it would be better to include
> > >> the minimum library version information right there in the config file
> > >> instead?
> > >
> > >No different from what happens when you update to a new version of
> > >Subversion that adds a new feature. The config files are already
> > >there, so they don't get written out again. Just the way it works ;-)
> >
> > I'm fine with that. I'm also going to be pretty busy until the
> > weekend, so feel free to revise and commit if you are comfortable with
> > it. Otherwise, I'll work on it this weekend.
> >
> > One more thing that needs to be fixed, I think, is that http_auth_str
> > needs to be apr_pstrdup'd before it is destroyed by the space
> > collapsing and tokenizing. The config stuff seems to hand you back
> > the same string from its hash all the time, so destroying it could
> > cause problems for clients other than the commandline (I think).
>
> Attached is a revised patch with these all suggested changes
> incorporated.
Looks good to me, +1 to commit.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 18 21:20:13 2006