Re: svn commit: r21528 - in branches/merge-tracking/subversion: libsvn_fs libsvn_fs_base libsvn_fs_fs

On Mon, 18 Sep 2006, Malcolm Rowe wrote:

> On Mon, Sep 18, 2006 at 10:38:25AM -0700, dlr@tigris.org wrote:
> > const svn_string_t *value, apr_pool_t *pool);
> > svn_error_t *(*root)(svn_fs_root_t **root_p, svn_fs_txn_t *txn,
> > apr_pool_t *pool);
> > + svn_error_t *(*get_mergeinfo)(apr_hash_t **minfoprops, svn_fs_txn_t *txn,
> > + apr_pool_t *pool);
> > } txn_vtable_t;
>
> Will we be adding a function to svn_fs.h - presumably named something
> like svn_fs_txn_mergeinfo()? - that allows external callers to call this
> vtable entry? (I'm slightly surprised that we didn't include it in this
> commit, actually, since that would be the ideal place to document what
> this call actually does).

While this API is currently used only inside the FS backends (which
access fs-loader.h's struct declarations through relative includes),
it might make sense to include a svn_fs.h API for this new hook for
general consumption. Thanks for the review, Malcom.

Kamesh, how does this fit in with your second patch? Should we add
the API separately?

- Dan