"Bhuvaneswaran Arumugam" <bhuvan@collab.net> writes:
> Any review comment on this?
Sorry for the delay. I've reviewed this, it looks good. Since you
have commit access, just go ahead and apply it (including the 'svn cp'
before patching, of course). You only need the "Approved by:" line in
the log message, the rest is assumed to default to the committer.
Best,
-Karl
> On Fri, 2006-09-08 at 11:46 +0530, Bhuvaneswaran Arumugam wrote:
>> On Thu, 2006-09-07 at 14:27 -0700, Karl Fogel wrote:
>> > "Bhuvaneswaran Arumugam" <bhuvan@collab.net> writes:
>> > > I noticed we have two identical Subversion license files
>> > > (www/license-1.html and www/project_license.html). I do not see any
>> > > difference between them except a pre-mature line wrap.
>> > >
>> > > Would it be good to retain one file (www/project_license.html) and
>> > > remove the other from our repo? Yeah, we should also correct the link in
>> > > many programs / scripts and point it to correct license file.
>> >
>> > There are probably references out in the world to both URLs, so at
>> > least an redirection would have to be retained. (I'd prefer to see
>> > just license.html, personally :-) ).
>>
>> Please find attached the patch for review. I did run the following
>> commands before creating this patch.
>> $ cd www
>> $ svn cp project_license.html license.html
>>
>> After applying the patch, the status is as follows:
>> $ svn status
>> M license-1.html
>> A + license.html
>> M project_license.html
>>
>> [[
>> Patch by: me
>> Suggested by: me
>> Approved by: kfogel
>>
>> www/license-1.html:
>> www/project_license.html:
>> * Automatically redirect the requests to license.html after 5 seconds.
>> Print the redirect message and provide a link to new license page.
>> www/license.html:
>> * New license file. It is copied from project_license.html.
>> ]]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 18 18:26:20 2006