[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: [PATCH] Improve mingw support

From: Matthias Miller <Blog_at_OutOfHanwell.com>
Date: 2006-09-15 01:52:25 CEST

(I previously sent this response from the wrong address. Please respond
to this e-mail address.)

Max Bowsher wrote:
>> -#ifdef WIN32
>> +#if defined(WIN32) && !defined(__MINGW32__)
> >From what I remember when I was more active in this sphere of things,
> adding a function to w32api should be pretty easy, so I'd suggest
> looking into that.

I'm also quite interested in a MinGW build and am pursuing a patch for

>> * libsvn_subr/config_win.c: Define the minimum IE version to 5.0, since
>> mingw32 doesn't seem to define this.
>> +#ifdef __MINGW32__
>> +# ifndef _WIN32_IE
>> +# define _WIN32_IE 0x0500
>> +# endif
>> +#endif
> That doesn't seem right at all. If we are setting these 'API level
> feature request' macros at all, we should be setting them for all
> windows compilers.

Also, we should define this macro before we include windows.h. I've
attached an updated patch, but I don't have a VC build environment, so I
can't confirm that it builds correctly there. It does the trick under MinGW.

-Matthias Miller

Index: subversion/libsvn_subr/config_win.c
--- subversion/libsvn_subr/config_win.c (revision 21476)
+++ subversion/libsvn_subr/config_win.c (working copy)
@@ -23,6 +23,7 @@
 #ifdef WIN32
 #define WIN32_LEAN_AND_MEAN
+#define _WIN32_IE 0x0500
 #include <windows.h>
 #include <shlobj.h>

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 15 01:52:59 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.