On 9/14/06, David Glasser <glasser@mit.edu> wrote:
> On 9/14/06, djames@tigris.org <djames@tigris.org> wrote:
> > +# To create a revision property is a bit more difficult, because we have
> > +# to set up a 'pre-revprop-change' hook script. These tests are skipped
> > +# on systems on which I don't know how to do that.
> > +SKIP: {
> > + skip "don't know how to create 'pre-revprop-change' hook script on $^O", 2
> > + if $^O eq 'MSWin32' || $^O eq 'MacOS';
> > +
> > + my $script_filename = "$repospath/hooks/pre-revprop-change";
> > + open my $script, '>', $script_filename
> > + or die "error creating hook script '$script_filename': $!";
> > + print $script "#!/bin/sh\nexit 0\n";
> > + close $script;
> > + chmod 0755, $script_filename
> > + or die "error making hook script '$script_filename' executable: $!";
>
> For what it's worth (and I don't have access to my Mac today), that
> method should work fine on OSX, which is essentially just Unix, so no
> need to skip. (And ditto for the same check in the other file, of
> course.)
Good catch. Actually, in the Perl world, $^O eq 'MacOS' refers to Mac
OS 9, which Subversion doesn't support at all.
I removed the check in r21496, and also fixed a small typo (we
actually skip *3* tests here, not *2*, so the count of skipped tests
is wrong).
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 14 20:22:44 2006