[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] simple optimization and new test case for 'svn cp URL wc'

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-09-14 19:03:12 CEST

On Thu, 10 Aug 2006, Madan S. wrote:

> On Wed, 09 Aug 2006 22:55:06 +0530, Daniel Rall <dlr@collab.net> wrote:
> >On Wed, 09 Aug 2006, Madan S. wrote:
> [snip]
> >> Also, I almost broke a case trying one more optimization - Using
> >>svn_wc_adm_open3() instead of svn_wc_adm_probe_open3(). But the tests
> >>kept
> >>passing - of course, that case was not being tested by the
> >>respos_to_wc()
> >>test of copy tests. So, I added it.
> >
> >Could you describe the test case? This is not enough context to
> >understand.
> If a target path of the copy operation already exists and is a directory,
> the source should be copied under the target directory. This specific case
> is not currently tested in repos_to_wc(). I inadverdently broke this
> functionality with some stupid simplifications, but the tests kept
> passing. Hence the itch to fix that.

Thanks Madan! Nice addition. I've committed the copy_tests.py change
to trunk in r21497.

  • application/pgp-signature attachment: stored
Received on Thu Sep 14 19:04:26 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.