[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Spuriously failing hook scripts

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-09-14 15:39:25 CEST

On 9/13/06, berni <bernhard_heibler@gmx.de> wrote:
> I have the same problem on a Dual Xeon Server running with Suse 10.0.
> By coincident I debugged this problem today and came to the same
> conclusion. I think it is a good idea to handle the
> !APR_STATUS_IS_CHILD_DONE condition since we get a proper error
> message.
>
> But to really solve the problem I think we should disable the SIGCHLD
> while the hook runs using the apr_signal function. I have done the
> following changes to 1.3.2 of hooks.c. Until now my hooks seam to work.
> But it would be great if someone else could test it !

Because signals are per-process, you can't just reset them like that
inside of a library like Subversion. If some other part of your
program depends on SIGCHLD you now have a window where it will not
work.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 14 15:39:40 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.